I think there must have been good times--a long period in which she and Feanor mostly just stayed out of each other's hair, before Melkor was released.
But it is hard to have the fundamental basis of your life questioned like that--and the end was clearly very bitter.